Skip to content

refactor: add enhanced useOpenClose controller to phase out toggleOpenClose #14040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elijbet wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

refactor: add enhanced useOpenClose controller to phase out toggleOpenClose #14040

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a042aa
refactor: add enhanced useOpenClose controller to phase out toggleOpe…
Elijbet Mar 9, 2026
4ab803b
accept multiple VisibilityProp
Elijbet Mar 10, 2026
0bfec9d
add shouldToggle guard, docs, refactors
Elijbet Mar 17, 2026
e563202
allow for options to be configured for customVisibilityProps for case…
Elijbet Mar 17, 2026
0bd6223
allow for options to be configured for customVisibilityProps for case…
Elijbet Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/components/src/components/block/block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { slotChangeGetAssignedElements, slotChangeHasAssignedElement } from "../
import { Heading, HeadingLevel } from "../functional/Heading";
import { FlipContext, Position, Scale, Status } from "../interfaces";
import { getIconScale } from "../../utils/component";
import { toggleOpenClose } from "../../utils/openCloseComponent";
import { useOpenClose } from "../../controllers/useOpenClose";
import {
defaultEndMenuPlacement,
FlipPlacement,
Expand Down Expand Up @@ -67,6 +67,8 @@ export class Block extends LitElement {

private interactiveContainer = useInteractive(this);

openCloseController = useOpenClose<this>()(this);

//#endregion

//#region State Properties
Expand Down Expand Up @@ -309,10 +311,6 @@ export class Block extends LitElement {
To account for this semantics change, the checks for (this.hasUpdated || value != defaultValue) was added in this method
Please refactor your code to reduce the need for this check.
Docs: https://webgis.esri.com/arcgis-components/?path=/docs/lumina-transition-from-stencil--docs#watching-for-property-changes */
if (changes.has("expanded") && (this.hasUpdated || this.expanded !== false)) {
toggleOpenClose(this);
}

if (changes.has("sortHandleOpen") && (this.hasUpdated || this.sortHandleOpen !== false)) {
this.sortHandleOpenHandler();
}
Expand Down
Loading
Loading