test(combobox): port filtering tests to browser mode#14060
Draft
test(combobox): port filtering tests to browser mode#14060
Conversation
jcfranco
added
the
skip visual snapshots
Contributor
There was a problem hiding this comment.
Pull request overview
Ports combobox filtering-related E2E coverage from Stencil’s newE2EPage runner to the Vitest browser-mode runner to address an unstable filtering/toggling test (Issue #14012).
Changes:
- Removed the
filteringtest suite fromcombobox.e2e.ts(Stencil E2E). - Added a new
describe("filtering")suite tocombobox.browser.e2e.tsxusingmount,userEvent, and browser-mode locators/commands. - Introduced browser-mode debounce handling via
DEBOUNCE.filterand mousecommandsutilities.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/components/src/components/combobox/combobox.e2e.ts | Removes the Stencil E2E filtering test suite being migrated. |
| packages/components/src/components/combobox/combobox.browser.e2e.tsx | Adds browser-mode implementations of the combobox filtering tests and related utilities/imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/components/src/components/combobox/combobox.browser.e2e.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/combobox/combobox.browser.e2e.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #14012
Summary
✨🧪✨