refactor(list): migrate tests to browser mode#14823
Draft
jcfranco wants to merge 3 commits into
Draft
Conversation
github-actions
Bot
added
the
refactor
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the calcite-list end-to-end tests from the legacy Puppeteer E2E harness to the newer Vitest browser-mode E2E setup, consolidating list behavior coverage into the *.browser.e2e.tsx suite.
Changes:
- Removed the legacy
list.e2e.tsPuppeteer-based tests. - Added equivalent (and in places consolidated) browser-mode E2E coverage for list-item coordination, filtering, selection/active behavior, keyboard navigation, and drag/sort interactions.
- Introduced browser mouse command helpers to support pointer-driven drag tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/components/src/components/list/list.e2e.ts | Removes the legacy Puppeteer E2E test suite for calcite-list. |
| packages/components/src/components/list/list.browser.e2e.tsx | Adds browser-mode E2E coverage replacing the removed legacy tests, including pointer drag support and updated interaction assertions. |
| await settleFilter(); | ||
| expect(parent.bordered).toBe(true); | ||
| expect(child.bordered).toBe(false); | ||
| parent.open = true; |
| const one = page.getBySelector("#one").element() as ListItem["el"]; | ||
| await expect.element(page.getBySelector("#one")).toHaveFocus(); | ||
| await userEvent.keyboard("{ArrowRight}"); | ||
| expect(one.open).toBe(true); |
| expect(document.activeElement?.tagName).toBe("CALCITE-ACTION"); | ||
| await userEvent.keyboard("{ArrowLeft}{ArrowLeft}{ArrowLeft}{ArrowLeft}"); | ||
| expect(document.activeElement).toBe(one); | ||
| expect(one.open).toBe(false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #11268
Summary
✨🧪✨