feat(design-tokens): remove default corner-radius token's reference#14829
Draft
matgalla wants to merge 3 commits into
Draft
feat(design-tokens): remove default corner-radius token's reference#14829matgalla wants to merge 3 commits into
matgalla wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the design-tokens build so corner-radius.default no longer emits as a CSS custom-property reference and instead resolves to a primitive 0, aligning the generated outputs with the intended token value behavior.
Changes:
- Remapped
semantic/corner-radius.defaultto reference the core size token{core.size.default.none}. - Simplified
stylesheetOutputReferencessocorner-radius.defaultis no longer forced to output as a reference. - Updated token build snapshots to expect
--calcite-corner-radius: 0;(and SCSS equivalent) rather than avar()reference.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/design-tokens/src/tokens/semantic/corner-radius.json | Remaps corner-radius.default to {core.size.default.none} to avoid retaining a semantic reference. |
| packages/design-tokens/src/config/index.ts | Removes the special-case that forced corner-radius.default to emit as a reference in stylesheets. |
| packages/design-tokens/tests/spec/snapshots/index.spec.ts.snap | Updates expected generated CSS/SCSS output to reflect the new primitive 0 value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #14765
Summary
corner-radius.default's value as a referencecorner-radius.default's value to a core token