perf(themed): speed up test helper#14832
Draft
jcfranco wants to merge 2 commits into
Draft
Conversation
github-actions
Bot
added
the
chore
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the themed() browser test helper used across packages/components to validate CSS token theming, aiming to reduce repeated interaction setup work during theme assertions.
Changes:
- Precomputes per-target assertion metadata (resolved elements, pseudo-element info, interaction targets) via
createThemeAssertion(). - Groups themed assertions by interaction element + state, performing the interaction once per group and asserting multiple properties afterward.
- Simplifies selector handling and consolidates repeated “target not found” error messaging.
Comment on lines
116
to
120
| it("is themeable", async () => { | ||
| const { el, container } = await setup(); | ||
| const elLocator = page.elementLocator(el); | ||
| await userEvent.unhover(el); | ||
|
|
||
| preventClicks(container); | ||
|
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jcfranco
added
the
skip visual snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
🧪🚀