refactor: use @cloudfour/simple-svg-placeholder instead of copying source#14867
Open
jcfranco wants to merge 1 commit into
Open
refactor: use @cloudfour/simple-svg-placeholder instead of copying source#14867jcfranco wants to merge 1 commit into
@cloudfour/simple-svg-placeholder instead of copying source#14867jcfranco wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
refactor
jcfranco
changed the title
@cloudfour/simple-svg-placeholder instead of copying source
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the in-repo copy of Cloud Four’s simple-svg-placeholder implementation used for Storybook/demo placeholder images, and instead uses the published @cloudfour/simple-svg-placeholder package (with typings) as the source of truth.
Changes:
- Replaced the local
placeholderImageimplementation with a direct re-export from@cloudfour/simple-svg-placeholder. - Added
@cloudfour/simple-svg-placeholderand@types/cloudfour__simple-svg-placeholderto rootdevDependencies. - Updated
package-lock.jsonto include the new dev dependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/.storybook/placeholder-image.ts | Replaces vendored placeholder implementation with a re-export from the upstream package. |
| package.json | Adds the upstream placeholder package and its type definitions as devDependencies. |
| package-lock.json | Locks the newly added devDependencies. |
jcfranco
added
the
pr ready for visual snapshots
jcfranco
marked this pull request as ready for review
July 23, 2026 00:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
✨🧹✨