-
Notifications
You must be signed in to change notification settings - Fork 11
chore: get build and test commands running under packages/common #2125
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the build and test tooling to enable independent operation within the packages/common directory. The main changes consolidate build and linting configurations at the package level rather than relying on monorepo-wide tooling.
Key Changes
- Moved linting and build tool dependencies from root to
packages/common/package.json - Inlined TypeScript configuration in
packages/common/tsconfig.jsoninstead of extending root config - Updated ESLint file path patterns to be relative to package root rather than monorepo root
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/common/package.json | Added dev dependencies (eslint, prettier, madge, etc.) and script commands for linting and circular dependency checking |
| packages/common/tsconfig.json | Replaced root config extension with inline configuration for standalone package compilation |
| packages/common/eslint.config.mjs | Updated file path patterns from absolute monorepo paths to package-relative paths |
| packages/common/.gitignore | Added standard ignores (coverage, dist, node_modules) for package artifacts |
| package.json | Removed root-level linting/madge dependencies and delegated lint/test commands to packages/common |
| support/generate-eslint-baseline.js | Deleted unused baseline generation utility |
| .eslintrc-baseline.js | Deleted unused baseline configuration file |
rweber-esri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is looking good to me. I was able to run npm i, build & test the project. I additionally verified ESLint is working as expected. One minor note relating to the linting.
This PR prepares hub-common to be moved to hub-ui by refactoring the build and test tooling to enable independent operation within the packages/common directory. The main changes consolidate build and linting configurations at the package level rather than relying on monorepo-wide tooling.
Key Changes
NOTE: These changes finally broke the Acetate based
docs:buildscript - so I have disabled that step.I also removed eslint from the pre-commit hook as it's no longer available at the root.
Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
Either ran
npm run changesetor this change does not require a release.These changes have been verified by QA using a
?uiVersionthat includes a PR-Preview of this branch and thev_reqlabel has been applied to the issue.OD-UI E2E tests pass against these changes using a
?uiVersionthat includes a PR-Preview of this branch