Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Conversation

@tomwayson
Copy link
Member

@tomwayson tomwayson commented Nov 14, 2025

  1. Description:

This PR prepares hub-common to be moved to hub-ui by refactoring the build and test tooling to enable independent operation within the packages/common directory. The main changes consolidate build and linting configurations at the package level rather than relying on monorepo-wide tooling.

Key Changes

  • Moved linting and build tool dependencies from root to packages/common/package.json
  • Inlined TypeScript configuration in packages/common/tsconfig.json instead of extending root config
  • Updated ESLint file path patterns to be relative to package root rather than monorepo root

NOTE: These changes finally broke the Acetate based docs:build script - so I have disabled that step.

I also removed eslint from the pre-commit hook as it's no longer available at the root.

  1. Instructions for testing:

  2. Closes Issues: # (if appropriate)

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. Either ran npm run changeset or this change does not require a release.

  5. These changes have been verified by QA using a ?uiVersion that includes a PR-Preview of this branch and the v_req label has been applied to the issue.

  6. OD-UI E2E tests pass against these changes using a ?uiVersion that includes a PR-Preview of this branch

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

⚠️ No Changeset found

Latest commit: 59bf7c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the build and test tooling to enable independent operation within the packages/common directory. The main changes consolidate build and linting configurations at the package level rather than relying on monorepo-wide tooling.

Key Changes

  • Moved linting and build tool dependencies from root to packages/common/package.json
  • Inlined TypeScript configuration in packages/common/tsconfig.json instead of extending root config
  • Updated ESLint file path patterns to be relative to package root rather than monorepo root

Reviewed Changes

Copilot reviewed 7 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/common/package.json Added dev dependencies (eslint, prettier, madge, etc.) and script commands for linting and circular dependency checking
packages/common/tsconfig.json Replaced root config extension with inline configuration for standalone package compilation
packages/common/eslint.config.mjs Updated file path patterns from absolute monorepo paths to package-relative paths
packages/common/.gitignore Added standard ignores (coverage, dist, node_modules) for package artifacts
package.json Removed root-level linting/madge dependencies and delegated lint/test commands to packages/common
support/generate-eslint-baseline.js Deleted unused baseline generation utility
.eslintrc-baseline.js Deleted unused baseline configuration file

Copy link
Contributor

@rweber-esri rweber-esri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is looking good to me. I was able to run npm i, build & test the project. I additionally verified ESLint is working as expected. One minor note relating to the linting.

@tomwayson tomwayson merged commit ac312d8 into master Nov 14, 2025
3 checks passed
@tomwayson tomwayson deleted the c/prep-for-hub-ui branch November 14, 2025 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants