ESSX Discord doesn't respect announceAdvancements gamerule when sending advancement message

[JellyBlade]

Type of bug

Other unexpected behaviour

/ess dump all output

https://essentialsx.net/dump.html?id=638bef65de1c46f38e109c26a6d2a24a

Error log (if applicable)

No response

Bug description

Disabling the announceAdvancement gamerule still allows the advancement message through to Discord. Current server setup has two worlds, creative and survival.

I created a plugin to revoke advancements made while in creative mode (simplest solution without modifying Multiverse) and disabled announceAdvancements in the creative world, but the message gets displayed in the primary discord channel anyway.

Ideally, advancement messages would still be enabled for the survival world, so disabling advancement messages on the bridge entirely is something I'd like to avoid.

Checking for whether or not the player's current world has the announceAdvancements gamerule enabled before sending the message would prevent this behaviour from occurring.

Steps to reproduce

1. Disable announceAdvancements gamerule.
2. Complete an advancement.
3. Message still gets displayed in the channel, even though the message for in-game chat is disabled.

Expected behaviour

Having the announceAdvancements gamerule disabled should prevent the message from appearing in discord.

Actual behaviour

The message is displayed regardless of the player's current world's announceAdvancements gamerule value.

[BornToDoStuff]

This bug also applies when using datapacks to control advancements such as Blaze and Caves advancements. The advancement announcement event is successfully canceled and does not appear in chat, to the player, or to the console, but is announced through the Discord connection regardless. I imagine the root reason is extremely similar or identical to the gamerule bug.