Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESSX Discord: Added a check for announceAdvancements gamerule #4866

Closed
wants to merge 1 commit into from
Closed

Conversation

JellyBlade
Copy link

Information

This PR fixes #4865.

Details

Proposed fix:
Added a check for the player's current world's announceAdvancements gamerule in the advancements listener to prevent the message from being sent if that gamerule is disabled for the world.

Environments tested:

OS: Windows 10 for client, assuming some version of Ubuntu LTS for the server (server provider doesn't specify, so assuming the same as what they run for VPS services)

Java version: Built on openjdk 17.0.1, ran on unknown version of Java 17 (server provider doesn't specify beyond 17)

  • Paper 1.18 (can upgrade server to test if necessary)
  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:
Before fix, while testing the gamerule
(Only the first one should've been sent, the rest are erroneous from the advancement being automatically revoked)
image
After fix, only one advancement sent, even after completing the criteria multiple times in a world with announceAdvancements disabled.
image

… bridge, preventing the advancement message from being sent to Discord if the gamerule is disabled for that world.
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be tested on Spigot & Paper 1.8 to Paper 1.18.2

This will break below 1.12 at the moment

@JRoy JRoy added status: waiting on author Pull requests that require changes from the author in order to merge. type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels Mar 23, 2022
@JRoy JRoy closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: discord Issues or PRs for the EssentialsDiscord module status: waiting on author Pull requests that require changes from the author in order to merge. type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESSX Discord doesn't respect announceAdvancements gamerule when sending advancement message
2 participants