Skip to content

Send completion notifications when renaming is disabled - #1083

Open
JSap0914 wants to merge 1 commit into
EstrellaXD:3.3-devfrom
JSap0914:fix/notification-without-renaming
Open

Send completion notifications when renaming is disabled#1083
JSap0914 wants to merge 1 commit into
EstrellaXD:3.3-devfrom
JSap0914:fix/notification-without-renaming

Conversation

@JSap0914

Copy link
Copy Markdown

Summary

  • return a download-completion notification when rename_method is none and the generated path is unchanged
  • keep the existing behavior of skipping the rename operation and not adding the ab:renamed tag
  • preserve unchanged-path behavior for normal rename methods

Fixes #1082

Tests

  • uv run pytest src/test/test_renamer.py::TestRenameFile::test_none_method_notifies_without_rename_or_tag src/test/test_renamer.py::TestRenameFile::test_same_path_skipped -q (2 passed)
  • uv run pytest src/test/test_renamer.py -q (96 passed)
  • uv run pytest src/test -q -m 'not e2e' --basetemp <isolated-temp-dir> (2027 passed, 3 skipped, 27 deselected)
  • uv run ruff check src
  • uv run mypy src
  • uv run black --check src/module/manager/renamer.py src/test/test_renamer.py

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

@JSap0914 is attempting to deploy a commit to the estrellaxd's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant