Fix FlagValueType.fromFlagType: map Long to Int and Float to Double#111
Closed
EtaCassiopeia wants to merge 1 commit into
Closed
Fix FlagValueType.fromFlagType: map Long to Int and Float to Double#111EtaCassiopeia wants to merge 1 commit into
EtaCassiopeia wants to merge 1 commit into
Conversation
Owner
Author
|
Tested independently; closing in favor of #110. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hooks that filter by
supportedFlagTypes(spec 4.4.2.1) currently missLongandFloatevaluations becauseFlagValueType.fromFlagTypefalls them through toObject. Long is integral (same family asInt) and Float is fractional (same family asDouble), so they should map accordingly.Changes
core/src/main/scala-3/zio/openfeature/FlagValueType.scala: addLong → Int,Float → Doublecasescore/src/main/scala-2/zio/openfeature/FlagValueType.scala: same, for cross-buildcore/src/test/scala/zio/openfeature/HookSpec.scala: two new tests pinning the mappingCredit
Spotted in #110 by @guizmaii.
Test plan