Skip to content

fix: track sprint gate corpus fixture - #743

Merged
EtanHey merged 1 commit into
mainfrom
fix/gate-corpus-tracked-path
Sep 1, 2026
Merged

fix: track sprint gate corpus fixture#743
EtanHey merged 1 commit into
mainfrom
fix/gate-corpus-tracked-path

Conversation

@EtanHey

@EtanHey EtanHey commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • move the frozen sprint-gate corpus from docs.local/ to the tracked test-fixture path and update both path constants
  • unblock main's tracked-docs.local CI guard (1 tracked file before, 0 after)
  • keep the gate input available in clean clones and on the M1 without relying on a force-add that conflicts with the guard

The corpus is a 100% Git rename. Its SHA-256 remains aa79c2dc8bdf8fc3b6eab65f503aa8fab06e0ffe296cb8f17bf291fbb70e2c04; gate logic and corpus content are unchanged.

Previously, corpus availability depended on a force-add that conflicted with both .gitignore and the CI guard. Removing the tracked docs.local file to satisfy the guard would also remove the gate's required input. Moving it to an uncontested tracked path removes that latent fragility.

Test plan

  • pytest tests/test_sprint_gate.py -q — 11 passed
  • changed-only pre-push gate — 11 sprint-gate, 3 MCP registration, 40 isolated routing/eval, 1 Bun, and 1 shell regression passed
  • exact CI guard body — no tracked files under docs.local/
  • clean-clone pair review — tracked corpus materialized at tests/fixtures/sprint_gate/corpus.json

Review

  • local CodeRabbit pre-commit review: 0 findings
  • lead-routed independent Claude pair review: ACCEPT

— brainlayerCodex-a6df3baf (worker) · codex/gpt-5.6-sol


Note

Low Risk
Path-only change with identical corpus content; no gate logic or threshold changes.

Overview
Relocates the frozen sprint-gate corpus.json from docs.local/plans/... to tests/fixtures/sprint_gate/corpus.json (content unchanged) and updates the CORPUS constant in scripts/sprint_gate.py and tests/test_sprint_gate.py so the gate and tests read the same tracked fixture.

This removes reliance on a force-added file under docs.local, which conflicted with the tracked-docs.local CI guard and could break clean clones or M1 runs when the guard dropped that path. Gate behavior and corpus thresholds/queries are not modified—only where the JSON is loaded from.

Reviewed by Cursor Bugbot for commit 0c17d73. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Move sprint gate corpus fixture to tests/fixtures/sprint_gate/corpus.json

Relocates the corpus data file out of docs.local/plans/... into tests/fixtures/sprint_gate/ and updates the CORPUS constant in both sprint_gate.py and test_sprint_gate.py to match.

Macroscope summarized 0c17d73.

Co-Authored-By: brainlayerCodex-a6df3baf running gpt-5.6-sol <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@cursor

cursor Bot commented Sep 1, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_8d742154-cf85-4aad-9e1d-cfd56af6ee86)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T14:31:50.632221Z 0c17d73 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: a27a61c9-67ef-4ae8-92d3-e63cb10b2149


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtanHey EtanHey added the XS Extra-small change (400 lines or fewer) label Sep 1, 2026
@EtanHey

EtanHey commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

@codex review

— brainlayerCodex-a6df3baf (worker) · codex/gpt-5.6-sol

@deepsource-io

deepsource-io Bot commented Sep 1, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in b8e7c7e...0c17d73 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Sep 1, 2026 2:30p.m. Review ↗
Swift Sep 1, 2026 2:30p.m. Review ↗
JavaScript Sep 1, 2026 2:30p.m. Review ↗
Shell Sep 1, 2026 2:30p.m. Review ↗
Secrets Sep 1, 2026 2:30p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 0c17d735ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@EtanHey
EtanHey merged commit 4fee4b3 into main Sep 1, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

XS Extra-small change (400 lines or fewer)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant