Load events when scrolling in month view #2018
Open
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspricke
reviewed
Jan 1, 2026
Comment on lines
489
to
490
| mHandler.removeCallbacks(mUpdateLoader); | ||
| mHandler.postDelayed(mUpdateLoader, LOADER_DELAY); |
Member
There was a problem hiding this comment.
This is the same as the else case from onScrollStateChanged but you are deleting the if case there, can you give a reason why?
Contributor
Author
There was a problem hiding this comment.
The onScroll method has no idle state. It is triggered continuously as long as the user scrolls.
Member
There was a problem hiding this comment.
ok, let me put it differently: why can we drop the stopLoader() call in line 490 then?
Contributor
Author
There was a problem hiding this comment.
This must be removed because otherwise the onScroll method will not work. I want the loader to be executed when scrolling. Or, conversely, it should be possible to reinsert mUpdateLoader into the handler queue in the onScroll method.
Gitsaibot
force-pushed
the
eventLoading
branch
3 times, most recently
from
9ede086 to
f85e593
Compare
Increase WEEKS_BUFFER to 6 to load additional weeks around the visible area in the monthly view. Add onScroll method to load events without removing your finger from the display Removal of the delay in the onScrollStateChanged method so that events are displayed immediately when you remove your finger from the display.
Gitsaibot
force-pushed
the
eventLoading
branch
from
f85e593 to
5c7427f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2016