Skip to content

refactor: goodbye KeyBindEvents, hello InputAction #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Bronya-Rand
Copy link
Contributor

This PR does the following. There's a lot so gonna word this in steps.

  1. Resolves Issue [Request] Ability to change freecam movement keybinds #156 on setting Free Camera keybinds.
  2. Removes KeyBindEvents

    This key system just doesn't handle hold press actions which is needed for some sections of code.

  3. Removes InputConfiguration and InputService.

    These relied on the old event code so I rewrote them from the ground up.

  4. New InputManagerService and InputManagerConfiguration.

    This should now handle keys similar to KeyboardFrame without the jank.

  5. New KeyConfig.

    Basically holds the key data in Brio back to Dalamud and the rest of Brio itself.

  6. Recoded every file using old KeyBindEvent logic for KeyConfig and such.

This is a very lengthy PR and right now XIV controls can interfere with some button selections, but it should be all good to go here (hopefully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant