Fix: missing import, multi-sig persistence, Friendbot error handling, and exchange rate - #379
Merged
Mystery-CLI merged 4 commits intoApr 23, 2026
Conversation
…atabase via Prisma
|
@GoodnessJohn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #215 — Add missing
LanguageSelectorimport (frontend/src/App.jsx)was rendered in JSX but never imported, causing a runtime crash. Added:
import { LanguageSelector } from './components/LanguageSelector';
──────────────────────────────────────────────────────────────────────────────────────────────────────────────
closes #217 — Persist pending multi-sig transactions to database (
backend/src/services/multiSig.js,backend/prisma/schema.prisma)Pending multi-sig transactions were stored in a module-level Map, which is wiped on every server restart,
crash, or when running multiple instances.
submitMultiSigTransaction, getPendingTransactions, and getPendingTransaction with prisma.pendingMultiSigTx
CRUD operations
──────────────────────────────────────────────────────────────────────────────────────────────────────────────
closes #221 — Check Friendbot response status (
backend/src/services/stellar.js)The Friendbot fetch call was fire-and-forget — a non-2xx response (rate limit, account already exists, network
error) was silently swallowed and the account was returned as if it were funded. Now checks response.ok and
throws a descriptive error on failure:
const friendbotRes = await fetch(
https://friendbot.stellar.org?addr=${publicKey});if (!friendbotRes.ok) {
throw new Error(
Friendbot funding failed: ${friendbotRes.status} ${friendbotRes.statusText});}
──────────────────────────────────────────────────────────────────────────────────────────────────────────────
closes #222 — Return 503 when exchange rate is unavailable (
backend/src/routes/stellar.js)When the orderbook had no asks, getRate returned null and the route responded { from, to, rate: null } with
HTTP 200, making it indistinguishable from a valid zero rate. The route handler now returns a 503 with a
descriptive message when rate === null.