remote update feature #1060
Open
remote update feature #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Franky, |
|
I see @eaescob doing something similar on his repo, I'm still not that good at writing code :) |
|
This is awesome! Yeah, libcurl just looks cleaner (IMO). Let me see if I can take a stab at it based on what you've written. Regarding the fingerprints, can you two please look at my question posted in #1058 ? |
LocutusOfBorg
force-pushed
the
update
branch
2 times, most recently
from
b4f6660 to
061a8a0
Compare
LocutusOfBorg
force-pushed
the
update
branch
from
dc0beda to
1417172
Compare
Make the update feature optional and disabled by default
LocutusOfBorg
force-pushed
the
update
branch
from
adeb944 to
812c4d5
Compare
[ 51%] Building C object src/CMakeFiles/lib_ettercap.dir/dissectors/ec_ssh.c.o
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:560:52: error:
variable 'm_h_n' is uninitialized when used here [-Werror,-Wuninitialized]
temp_session_id=ssh_session_id(cookie, m_h_n, m_s_n);
^~~~~
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:146:29: note:
initialize the variable 'm_h_n' to silence this warning
BIGNUM *h_n, *s_n, *m_h_n, *m_s_n;
^
= NULL
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:560:59: error:
variable 'm_s_n' is uninitialized when used here [-Werror,-Wuninitialized]
temp_session_id=ssh_session_id(cookie, m_h_n, m_s_n);
^~~~~
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:146:37: note:
initialize the variable 'm_s_n' to silence this warning
BIGNUM *h_n, *s_n, *m_h_n, *m_s_n;
^
= NULL
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:552:54: error:
variable 'h_n' is uninitialized when used here [-Werror,-Wuninitialized]
temp_session_id = ssh_session_id(cookie, h_n, s_n);
^~~
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:146:15: note:
initialize the variable 'h_n' to silence this warning
BIGNUM *h_n, *s_n, *m_h_n, *m_s_n;
^
= NULL
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:552:59: error:
variable 's_n' is uninitialized when used here [-Werror,-Wuninitialized]
temp_session_id = ssh_session_id(cookie, h_n, s_n);
^~~
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:146:21: note:
initialize the variable 's_n' to silence this warning
BIGNUM *h_n, *s_n, *m_h_n, *m_s_n;
^
= NULL
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:398:64: error:
variable 's_d' is uninitialized when used here [-Werror,-Wuninitialized]
RSA_set0_key(session_data->serverkey, s_n, s_e, s_d);
^~~
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:148:21: note:
initialize the variable 's_d' to silence this warning
BIGNUM *h_d, *s_d, *m_h_d, *m_s_d;
^
= NULL
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:409:62: error:
variable 'h_d' is uninitialized when used here [-Werror,-Wuninitialized]
RSA_set0_key(session_data->hostkey, h_n, h_e, h_d);
^~~
/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:148:15: note:
initialize the variable 'h_d' to silence this warning
BIGNUM *h_d, *s_d, *m_h_d, *m_s_d;
^
= NULL
6 errors generated.
make[2]: *** [src/CMakeFiles/lib_ettercap.dir/build.make:1197: src/CMakeFiles/lib_ettercap.dir/dissectors/ec_ssh.c.o] Error 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.