fix: raise an error if a self reference is detected#42
Closed
bart-westenenk-bex wants to merge 3 commits intoEugZol:masterfrom
Closed
fix: raise an error if a self reference is detected#42bart-westenenk-bex wants to merge 3 commits intoEugZol:masterfrom
bart-westenenk-bex wants to merge 3 commits intoEugZol:masterfrom
Conversation
bart-westenenk-bex
changed the title
bart-westenenk-bex
force-pushed
the
41-fix-inner-database-table-shadowing
branch
from
e7686fc to
4ca2ed4
Compare
bart-westenenk-bex
force-pushed
the
41-fix-inner-database-table-shadowing
branch
from
1d703a7 to
af37d0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it impossible to make mistakes by joining the parent record in the where_exists scope. Doing this will result in the inner join table declaration shadowing the outer table declaration resulting in the exists subquery returning all records, thus basically reducing itself to a
where (SELECT 1 FROM 'target_table')refs #41