feat(client): support gssapi-with-mic auth - #738
Merged
Conversation
Owner
|
Thank you! @all-contributors add @ayamir for code |
Contributor
|
I've put up a pull request to add @ayamir! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add client-side support for the RFC 4462
gssapi-with-micuserauth method. This keeps russh responsible for the SSH protocol flow while leaving platform GSSAPI/Kerberos integration to callers through a newGssapiAuthenticatortrait. Callers provide DER-encoded mechanism OIDs, consume server GSS tokens, and return continuation tokens or the final MIC.Changes
MethodKind::GssapiWithMic/Method::GssapiWithMicUSERAUTH_GSSAPI_RESPONSE = 60USERAUTH_GSSAPI_TOKEN = 61USERAUTH_GSSAPI_EXCHANGE_COMPLETE = 63USERAUTH_GSSAPI_ERROR = 64USERAUTH_GSSAPI_ERRTOK = 65USERAUTH_GSSAPI_MIC = 66GssapiAuthenticatorandGssapiStepHandle::authenticate_gssapi_with_micDesign Notes
This PR intentionally does not add a dependency on a system GSSAPI library.
Different callers may want to use platform GSS.framework, MIT Kerberos, Heimdal, SSPI, or a fake/test implementation. The trait boundary keeps that platform policy outside russh.
The intended layering is:
Verification
cargo fmt --checkcargo test -p russh gssapicargo check -p russhcargo test -p russh