Merged
Conversation
tmichela
reviewed
Feb 18, 2026
Thanks Thomas M.! Co-authored-by: Thomas Michelat <32831491+tmichela@users.noreply.github.com>
tmichela
reviewed
Feb 18, 2026
| family_name: str | ||
| given_name: str | ||
| groups: list[str] | ||
| groups: list[str] = Field(default_factory=list) |
Member
There was a problem hiding this comment.
Also there are now non-default arguments following this default argument. Is this a problem with Pydantic? I know it is with dataclasses.
Member
Author
There was a problem hiding this comment.
When using BaseModel, ordering of field with(out) defaults is not strict (there's also an example in their docs). If pydantic.dataclasses.dataclass is used, it will be strict like in the built-in dataclasses.
Quick fix: we just mount the `certs` folder on the production Docker compose file. (also copied the necessary certs on that folder in the production host)
Member
Author
|
Merging now, thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like some users do not have EuXFEL-related groups. We make this optional, which shouldn't case much problems as it is not used for the meantime.