Skip to content

fix(api/metadata): resolve damnit paths #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CammilleCC merged 2 commits into from
Mar 3, 2026
Merged

fix(api/metadata): resolve damnit paths #188

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7167560
fix(api/metadata): resolve damnit paths
CammilleCC Mar 2, 2026
2bf5891
fix(api/metadata): use usr/Shared path directly
CammilleCC Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/src/damnit_api/metadata/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ async def _fetch_proposal_meta(
await logger.adebug(
"Damnit path info",
damnit_path=damnit_path,
damnit_paths_searched=[str(p.relative_to(path)) for p in damnit_paths_searched],
damnit_paths_searched=[str(path) for p in damnit_paths_searched],
)

principal_investigator = None
Expand Down Expand Up @@ -103,13 +103,13 @@ async def _search_damnit_dir(path: Path) -> tuple[Path | None, list[Path]]:
searched_paths = []
for dir in ("amore", "amore-online"):
try:
damnit_path = damnit_path = usr_share.parent / dir
damnit_path = await (usr_share.parent / dir).resolve()
searched_paths.append(Path(damnit_path))
if await damnit_path.is_dir():
return Path(damnit_path), searched_paths
except PermissionError:
await logger.awarning(
f"Permission denied when accessing {usr_share.parent / dir}"
f"Permission denied when accessing {damnit_path}"
)
continue

Expand Down