Rough sketch of listening to Kafka for update notifications#199
Draft
takluyver wants to merge 1 commit into
Draft
Rough sketch of listening to Kafka for update notifications#199takluyver wants to merge 1 commit into
takluyver wants to merge 1 commit into
Conversation
takluyver
force-pushed
the
feat/kafka-updates
branch
from
6c50ee2 to
4df9b74
Compare
takluyver
force-pushed
the
feat/kafka-updates
branch
from
4df9b74 to
15f502a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@CammilleCC this probably won't work as is, I haven't tried to test it at all, but it's meant to be a starting point for using Kafka notifications rather than polling.
The idea is that when the first client subscribes to a proposal, it creates and starts a
DBWatcherobject. Extra subscribers then get added to that, so they only hit the database once. When a subscription is closed, the generator task should be cancelled, and the last subscriber should also cancel the DBWatcher.