feat(api/auth): use strawberry/gql permission classes#200
Open
RobertRosca wants to merge 9 commits into
Open
Conversation
Member
|
I've quickly rebased and tested it, it seems working nicely 😊 Can you please add a test fora denied path on |
…/ nice exception previously would have given 500 error due to potentially missing session
RobertRosca
force-pushed
the
feat/strawberry-permissions
branch
from
b6b2129 to
6239140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR updates gql auth/z code to use Strawberry's 'native' permission model (classes inheriting
BasePermission, withpermission_classes=...on fields) instead of implicit authentication within_ensure_proposal_damnit_path.Adds
IsAuthenticatedandIsProposalMemberclasses, included in@strawberry.field(permission_classes=...)where appropriate.Makes
_ensure_proposal_damnit_pathonly deal with checking proposal has damnit path (removing auth/z responsibilities) and renames the function to_ensure_damnit_path.