Fix one_key() not finding a key for CONTROL sources with a selection - #648
Merged
Conversation
philsmt
commented
Aug 5, 2025
| """ | ||
| if self.sel_keys is not None: | ||
| if index_group is None: | ||
| if index_group is None or self.is_control: |
Contributor
Author
There was a problem hiding this comment.
One could also change this to if not index_group, but this seemed more explicit to me.
Member
|
LGTM |
Contributor
Author
|
Thanks for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceData.one_key(index_group=None)may be called with''forindex_groupin the case ofCONTROLsources internally, which is meant to be supported throughout the stack. This fails however in the case of a key selection, as this enters a different branch not handling it properly. I suspect this fell through given the lack of test for it specifically.Oddly enough I found this bug through
exdf-toolsreductions, where one would have assumed it should've come up sooner 🤷