More efficient det.split_trains() for long runs - #758
Open
takluyver wants to merge 2 commits into
Open
Conversation
takluyver
force-pushed
the
perf/det-split-trains
branch
2 times, most recently
from
August 4, 2026 19:49
5d52f5d to
7e776d1
Compare
takluyver
force-pushed
the
perf/det-split-trains
branch
from
August 4, 2026 20:33
7e776d1 to
2fd6a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow detector components to benefit from the more efficient splitting code in
SourceData.split_trains().Testing with a long run (~18k trains), splitting to 16 trains per part went from ~14 seconds to ~0.5 seeconds.
I've also allowed
frames_per_partto use the fast code path where there's a fixed number of frames per train.