FastADC component - #516
Draft
fadybishara wants to merge 20 commits into
Draft
Conversation
added 20 commits
June 26, 2026 16:09
… and refactored the source matching logic accordingly
…use with FastADC component and updated adq.py accordingly
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
==========================================
- Coverage 73.72% 73.26% -0.47%
==========================================
Files 35 37 +2
Lines 6927 7133 +206
==========================================
+ Hits 5107 5226 +119
- Misses 1820 1907 +87 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally, here is a minimal working implementation! It is not complete yet but it's time to discuss the API, the basic structure and since this implementation is already functional, we need to decide what additional features should be implemented before making the first merge.
In particular, tere are two stub methods:
.find_peaksand.pull_baseline. The question is how sophisticated they should be in this component. For example, SCS does baseline subtraction pulse by pulse. This can easily be implemented here using the._pull_to_baselevelfunction in the newly createddigitizers.pymodule.Speaking of the digitizers module, more static methods from the ADQ component need to be moved there.
Once we come to an agreement, I will update and expand the doc strings and will write unit tests before a full-fledged PR can be merged.