-
Notifications
You must be signed in to change notification settings - Fork 2
release: v0.0.4 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Tohrusky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a standard release preparation step, focusing solely on updating the version number of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the package version to 0.0.4 for a new release. The version is updated in both cccv/__init__.py and pyproject.toml. While the change is correct, I've provided a suggestion to improve maintainability by using a single source of truth for the version number, which will simplify future releases.
| """ | ||
|
|
||
| __version__ = "0.0.3" | ||
| __version__ = "0.0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid potential inconsistencies between pyproject.toml and this file, it's a good practice to define the version number in a single place. pyproject.toml is a good candidate for this single source of truth.
You can dynamically read the version from the installed package metadata in __init__.py. This way, you only need to update the version in pyproject.toml for future releases.
Since your project requires Python >= 3.9, you can use the standard importlib.metadata library. Here's an example of how you could implement this:
# In cccv/__init__.py, instead of the hardcoded __version__
from importlib.metadata import PackageNotFoundError, version
try:
__version__ = version("cccv")
except PackageNotFoundError:
# The package is not installed, which can happen in development.
# Fallback to a development version.
__version__ = "0.0.0-dev"Adopting this pattern will make your release process more robust and less error-prone.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 40 40
Lines 1216 1216
=======================================
Hits 1128 1128
Misses 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.