Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

Conversation

@Tohrusky
Copy link
Member

@Tohrusky Tohrusky commented Feb 11, 2025

Summary by Sourcery

Release version 0.0.2.

New Features:

  • Add FP16 support for inference.

Tests:

  • Update model tests to support FP16 inference.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 11, 2025

Reviewer's Guide by Sourcery

This PR introduces support for fp16 precision during the image inference process in both DRBA and RIFE models by conditionally converting tensors to half precision, and it also updates the project version to v0.0.2.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added fp16 support in the DRBA model inference.
  • Inserted a conditional check to convert image tensors to half precision if fp16 is enabled.
  • Ensured the conversion occurs before appending the tensor to the list for stacking.
ccvfi/model/drba_model.py
Added fp16 support in the RIFE model inference.
  • Inserted a conditional check to convert image tensors to half precision if fp16 is enabled.
  • Ensured the conversion occurs before appending the tensor to the list for stacking.
ccvfi/model/rife_model.py
Updated project version from v0.0.1 to v0.0.2.
  • Modified the version field in the pyproject.toml file.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Tohrusky Tohrusky merged commit 7626b74 into EutropicAI:main Feb 11, 2025
12 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Tohrusky - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider consolidating the duplicate fp16 logic into a shared utility function or base class.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant