Skip to content

fix: support SDK 54 BaseMods API and multiple widget-type targets #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackrobinsonuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support SDK 54 BaseMods API and multiple widget-type targets #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/apple-targets/src/with-bacons-xcode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
import { XcodeProject } from "@bacons/xcode";
import * as xcodeParse from "@bacons/xcode/json";
import {
BaseMods,
ConfigPlugin,
createRunOncePlugin,
IOSConfig,
Mod,
withMod,
} from "expo/config-plugins";
// BaseMods.withGeneratedBaseMods and BaseMods.provider were moved to standalone
// exports in @expo/config-plugins SDK 54
import {
provider,
withGeneratedBaseMods,
} from "@expo/config-plugins/build/plugins/createBaseMod";
import fs from "fs";

const customModName = "xcodeProjectBeta2";
Expand All @@ -24,13 +29,13 @@ export const withXcodeProjectBeta: ConfigPlugin<Mod<XcodeProject>> = (
};

const withXcodeProjectBetaBaseModInternal: ConfigPlugin = (config) => {
return BaseMods.withGeneratedBaseMods(config, {
return withGeneratedBaseMods(config, {
platform: "ios",
saveToInternal: true,
skipEmptyMod: false,
providers: {
// Append a custom rule to supply AppDelegate header data to mods on `mods.ios.AppClipInfoPlist`
[customModName]: BaseMods.provider<XcodeProject>({
[customModName]: provider<XcodeProject>({
isIntrospective: false,
// isIntrospective: true,
async getFilePath({ modRequest, _internal }) {
Expand Down
3 changes: 1 addition & 2 deletions packages/apple-targets/src/with-xcode-changes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ async function applyXcodeChanges(
const productName = props.productName;

let targetToUpdate: PBXNativeTarget | undefined =
targets.find((target) => target.props.productName === productName) ??
targets[0];
targets.find((target) => target.props.productName === productName);

if (targetToUpdate) {
warnOnce(
Expand Down