Skip to content

Handle adaptive icons with dynamic app icon - #53

Open
russriser wants to merge 5 commits into
EvanBacon:mainfrom
moodworksinc:main
Open

Handle adaptive icons with dynamic app icon#53
russriser wants to merge 5 commits into
EvanBacon:mainfrom
moodworksinc:main

Conversation

@russriser

Copy link
Copy Markdown

I'm opening this PR just for awareness that using Adaptive Icons as dynamic icons is doable with a fork like this.

Basically, withAndroidAppIcon was already handling Adaptive Icons for the shortcuts, so we can just reuse that logic for the App Icon in withAndroidDynamicAppIcon. Then, we just need to handle the adaptive icon input props in withAppIcon.

I updated the build scripts just to get them working on my machine.

Sorry I don't have more time to submit a more formal contribution.

@russriser

Copy link
Copy Markdown
Author

For context, there are many "expo dynamic app icon" packages out there, but most of them are out of date and unmaintained. New ones spawn with every expo version update, and its annoying to find a new one every time. @EvanBacon seems to do a good job at keeping this package up-to-date with expo, so I decided that forking this and merging in future updates might be easier than switching packages every few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant