Handle adaptive icons with dynamic app icon - #53
Open
russriser wants to merge 5 commits into
Open
Conversation
Author
|
For context, there are many "expo dynamic app icon" packages out there, but most of them are out of date and unmaintained. New ones spawn with every expo version update, and its annoying to find a new one every time. @EvanBacon seems to do a good job at keeping this package up-to-date with expo, so I decided that forking this and merging in future updates might be easier than switching packages every few months. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this PR just for awareness that using Adaptive Icons as dynamic icons is doable with a fork like this.
Basically, withAndroidAppIcon was already handling Adaptive Icons for the shortcuts, so we can just reuse that logic for the App Icon in withAndroidDynamicAppIcon. Then, we just need to handle the adaptive icon input props in withAppIcon.
I updated the build scripts just to get them working on my machine.
Sorry I don't have more time to submit a more formal contribution.