Skip to content

Conversation

@stricoff92
Copy link

Hello,

I'm confused as to why isPlaying is hidden from the public api? Am I missing something? I added a getter in this PR.

Thanks

@EvandroLG
Copy link
Owner

Hey @stricoff92

Good catch! I actually thought this was already exposed as part of the public API (we have it even documented in the lib docs). Thanks for pointing it out!

To move forward with your PR, could you please update the unit tests as well? https://github.com/EvandroLG/ts-audio/blob/master/src/audio/__tests__/Audio.test.ts#L12?

@stricoff92
Copy link
Author

Hey @stricoff92

Good catch! I actually thought this was already exposed as part of the public API (we have it even documented in the lib docs). Thanks for pointing it out!

To move forward with your PR, could you please update the unit tests as well? https://github.com/EvandroLG/ts-audio/blob/master/src/audio/__tests__/Audio.test.ts#L12?

I added tests to the audio test suite. I'm not super familiar with unit testing in JS... so let me know if you expected something different. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants