#4171 [Digirisk] fix: php8 warnings #4335
Open
+30
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evarisk-micka
requested changes
May 6, 2025
| @@ -254,7 +254,7 @@ public function selectDigiriskElementList($selected = '', $htmlname = 'fk_elemen | |||
| { | |||
| global $conf, $form, $langs; | |||
|
|
|||
| if (dol_strlen($filter['customsql'])) { | |||
| if (!empty($filter['customsql']) && dol_strlen($filter['customsql'])) { | |||
There was a problem hiding this comment.
Si !empty($filter) alors il est forcément rempli c'est redondant, il faut plutôt vérifier si dol_strlen est supérieur à > 0 pour retirer le warning ou seulement laisser !empty()
| @@ -254,7 +254,7 @@ public function selectDigiriskElementList($selected = '', $htmlname = 'fk_elemen | |||
| { | |||
| global $conf, $form, $langs; | |||
|
|
|||
| if (dol_strlen($filter['customsql'])) { | |||
| if (!empty($filter['customsql']) && dol_strlen($filter['customsql'])) { | |||
There was a problem hiding this comment.
Si !empty($filter) alors il est forcément rempli c'est redondant, il faut plutôt vérifier si dol_strlen est supérieur à > 0 pour retirer le warning ou seulement laisser !empty()
| @@ -346,7 +346,7 @@ public function select_preventionplan_list($selected = '', $htmlname = 'fk_preve | |||
| { | |||
| global $form; | |||
|
|
|||
| if (dol_strlen($filter['customsql'])) { | |||
| if (!empty($filter['customsql']) && dol_strlen($filter['customsql'])) { | |||
| if ( ! $evalsortfield) $evalsortfield = "evaluation." . key($evaluation->fields); | ||
| if (empty($sortfield)) $sortfield = $conf->global->DIGIRISKDOLIBARR_SORT_LISTINGS_BY_COTATION ? "evaluation.cotation" : "r." . key($risk->fields);; // Set here default search field. By default 1st field in definition. | ||
| if (empty($sortorder)) $sortorder = $conf->global->DIGIRISKDOLIBARR_SORT_LISTINGS_BY_COTATION ? "DESC" : "ASC" ; | ||
| if (empty($evalsortfield)) $evalsortfield = "evaluation." . key($evaluation->fields); |
There was a problem hiding this comment.
Ce bloc est également présent dans les fichiers firepermit_list, evaluator, risk, risksign, risk_list, etc... tant qu'à clean les warning autant ctrl + alt + f pour voir toute les occurrences et les réparer pour ne plus avoir à s'en soucier plus tard
evarisk-micka
changed the title
evarisk-micka
moved this to Pull requests
in DigiRisk 21.1.0 - Simplification et améliorations des enquêtes accidents
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.