-
Notifications
You must be signed in to change notification settings - Fork 212
fix: Treat series literals as list type #4370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
25990e6
to
b55f7a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4370 +/- ##
=======================================
Coverage ? 77.50%
=======================================
Files ? 846
Lines ? 114644
Branches ? 0
=======================================
Hits ? 88856
Misses ? 25788
Partials ? 0
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that series to literal conversion is problematic right now, however I am worried that disabling/hiding it would be a breaking change.
Do you know where series literals are actually being used? Should we just treat them as list type?
The series lists are used kinda everywhere. On the expressions side, they are used in They are also used internally, such as for adding generated / partition fields on reads (i.e. adding a column of partition values from catalog / adding a column for file path) and in the SQL parser for tuples. To me, the main benefit of this is that we can wrap series in expressions, such that when we eval the expression (in functions that expect expressions) it just returns the series. Tbh the main problem i just wanna solve is i don't want user to do If they are tryna broadcast a list, something like |
Just adding on, i think the current behavior of doing Like u said, instead of removing it, we can keep it the ability to do Either way it will be breaking change tho because we are changing the behavior (i guess this can be considered a bug fix too? lets just err on the safe side and put this in 0.5) |
c08c846
to
f5128e5
Compare
Changes Made
For series literals created from public api, wrap them in a list array. This is so that we don't get any broadcasting issues.
Additionally adds the ability to create List literals, i.e.
daft.lit([1,2,3])
Related Issues
Fixes #3287 and #1992
Checklist
docs/mkdocs.yml
navigation