-
Notifications
You must be signed in to change notification settings - Fork 381
feat(swordfish): Streaming sources #5978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
colin-ho
wants to merge
18
commits into
main
Choose a base branch
from
colin/stremaing-sources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49bd008 to
23abefb
Compare
b09e4e3 to
eb2d3e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Stacked on #5976
This PR enables sources to be streaming sources in swordfish. Currently, all our sources (in memory / scan task / glob) require a fixed set of inputs, and this PR refactors them such that they can continuously accept inputs. This works by
Inputsstruct, and the swordfish pipeline nodes now store a receiver, e.g.Receiver<(InputID, ScanTask)>, that the sources pull from when they are started.NativeExecutorholds the senders into the new streaming sources, and is responsible for enqueuing the inputs.FOR NOW, the pipelines themselves are still short lived,
NativeExecutor.runaccepts both plan and inputs, and immediately starts the plan and enqueues the inputs and thats it. In the next PR, I will implement the ability to have the pipelines be long lived with continuous input enqueuing. (this will require the input_id in the morsels as well as flushing mechanism).Related Issues