-
Notifications
You must be signed in to change notification settings - Fork 493
feat(temporal): add Spark-style timezone conversions #6919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BABTUNA
wants to merge
12
commits into
Eventual-Inc:main
Choose a base branch
from
BABTUNA:feat/temporal-tz-conversions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
73b0b72
feat(temporal): add Spark-style timezone conversions
BABTUNA 9339879
chore(temporal): address Greptile review on tz conversions
BABTUNA a6f6608
Merge remote-tracking branch 'origin/main' into feat/temporal-tz-conv…
BABTUNA 84d8237
Merge branch 'main' into feat/temporal-tz-conversions
madvart 56650e3
ci: retrigger to clear flaky shuffle and HuggingFace 429
BABTUNA 5a1205a
Merge remote-tracking branch 'origin/main' into feat/temporal-tz-conv…
BABTUNA 29a8353
Merge remote-tracking branch 'origin/main' into feat/temporal-tz-conv…
BABTUNA fe8f72d
ci: retrigger flaky PyPI 503 / CodSpeed timeout
BABTUNA d28b087
Merge remote-tracking branch 'origin/main' into feat/temporal-tz-conv…
BABTUNA a561569
Merge remote-tracking branch 'origin/main' into feat/temporal-tz-conv…
BABTUNA 3975e24
ci: retrigger flaky test_to_torch_dataloader_batches
BABTUNA 094d63d
ci: retrigger flaky HuggingFace ReadTimeout / model load
BABTUNA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naive_local_to_timestamppropagatesDaftError::ValueErrorfor both ambiguous times (DST fall-back) and nonexistent times (DST spring-forward). Spark instead silently resolves ambiguous times to the pre-transition offset and advances past the gap for nonexistent times.A user migrating from Spark who has timestamps around a DST boundary will get a runtime error where Spark would have produced a result. The difference is worth documenting in the docstring even if the strict behavior is intentional.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented in the to_utc_timestamp docstring. Keeping the strict behavior for now. silently picking a side on DST transitions can be just as surprising as erroring.