Skip to content

fix(ci): pin maturin <1.14 to keep --timings=html working#7145

Open
XiaoHongbo-Hope wants to merge 1 commit into
Eventual-Inc:mainfrom
XiaoHongbo-Hope:fix/ci-maturin-timings
Open

fix(ci): pin maturin <1.14 to keep --timings=html working#7145
XiaoHongbo-Hope wants to merge 1 commit into
Eventual-Inc:mainfrom
XiaoHongbo-Hope:fix/ci-maturin-timings

Conversation

@XiaoHongbo-Hope

@XiaoHongbo-Hope XiaoHongbo-Hope commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

maturin 1.14.1 (released today) made --timings a boolean flag, rejecting --timings=html which integration-test-build uses. Every new PR fails this step and skips all downstream integration jobs (tpch, sql, ray, ai, catalogs, io).

Pin maturin<1.14 as a one-line workaround. Drop the pin once the --timings=html call site is migrated to 1.14's new flag shape.

error: unexpected value 'html' for '--timings' found; no more were expected

@XiaoHongbo-Hope XiaoHongbo-Hope requested a review from a team as a code owner June 20, 2026 02:44
@github-actions github-actions Bot added the fix label Jun 20, 2026
@greptile-apps

greptile-apps Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR pins maturin<1.14 in the integration-test-build job to work around a breaking change in maturin 1.14.1 where --timings=html was changed to a boolean flag, causing every integration test job to fail since they all depend on integration-test-build.

  • Adds an inline comment explaining the pin and the future unpin path (maturin<1.14 → drop the pin once the call-site flag is updated).
  • The pin is scoped only to integration-test-build; the two other jobs that install maturin (install-verify at lines 1691/1699) use maturin build without --timings=html and are unaffected.

Confidence Score: 5/5

Single-line CI fix that restores a broken install step; no production code is touched and the change cannot regress behavior.

The change adds an upper-bound pin to one uv pip install call and a comment. All other maturin usages in the workflow (maturin develop, and the two maturin build calls in install-verify) don't pass --timings=html and are unaffected. The pin is an accurate, minimal fix for the described breakage.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/pr-test-suite.yml Pins maturin<1.14 in the integration-test-build install step to keep --timings=html working; comment explains intent and the unpin path.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[integration-test-build] -->|uv pip install maturin &lt;1.14| B[maturin build --timings=html]
    B --> C[Upload wheels artifact]
    B --> D[Upload timings artifact]
    A --> E[integration-test-tpch]
    A --> F[integration-test-sql]
    A --> G[integration-test-ray]
    A --> H[integration-test-ai]
    A --> I[integration-test-catalogs]
    A --> J[integration-test-io]
    style A fill:#d4edda,stroke:#28a745
    style B fill:#d4edda,stroke:#28a745
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[integration-test-build] -->|uv pip install maturin &lt;1.14| B[maturin build --timings=html]
    B --> C[Upload wheels artifact]
    B --> D[Upload timings artifact]
    A --> E[integration-test-tpch]
    A --> F[integration-test-sql]
    A --> G[integration-test-ray]
    A --> H[integration-test-ai]
    A --> I[integration-test-catalogs]
    A --> J[integration-test-io]
    style A fill:#d4edda,stroke:#28a745
    style B fill:#d4edda,stroke:#28a745
Loading

Reviews (1): Last reviewed commit: "fix(ci): pin maturin <1.14 to keep --tim..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant