Skip to content

Initial nested options implement#1057

Open
Saplonily wants to merge 2 commits into
EverestAPI:devfrom
Saplonily:nested-options
Open

Initial nested options implement#1057
Saplonily wants to merge 2 commits into
EverestAPI:devfrom
Saplonily:nested-options

Conversation

@Saplonily

Copy link
Copy Markdown
Contributor

Closes #1015

This pr also fix submenus not being expanded by its items. (It's calculated but not used somehow, I don't know much about the details 🤔)

Absolutely this will make search box a bit useless, or should we have a feature that search box can search into nested menus?

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Jan 3, 2026
@SnipUndercover

Copy link
Copy Markdown
Member

Doesn't this conflict with #1005?

@Saplonily

Copy link
Copy Markdown
Contributor Author

Doesn't this conflict with #1005?

It's not the same "nest" way as it, it just focus another menu when entering a "submenu". Since we have true nested submenu supports in it, I can then base this implement on it later🤔

@Saplonily Saplonily marked this pull request as draft January 5, 2026 04:27
@maddie480-bot maddie480-bot added 0: draft This PR is not ready for review yet (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jan 5, 2026
@Saplonily

Copy link
Copy Markdown
Contributor Author

Tried using 'true' submenus, but it looks a little ugly. I personally would prefer this previous implement.

@Saplonily Saplonily marked this pull request as ready for review January 5, 2026 07:14
@maddie480-bot maddie480-bot added 1: review needed This PR needs 2 approvals to be merged (bot-managed) review needed and removed 0: draft This PR is not ready for review yet (bot-managed) labels Jan 5, 2026
@Wartori54

Copy link
Copy Markdown
Member

Looks like a solid new way to organize the mod options menu, I'd say that if we roll with it we should completely swap to that (so no NestedOptions toggle), but I can understand why people would like to have the ability to return to the current one. And definitely doesn't conflict with #1005 .

About the search option, it could still be useful regardless for overwhelmingly large mod option sections, and to search in the new initial options menu.

Given that this is a design focused PR I'd like other people to come in and share their opinion on this too.

@DashingCat

Copy link
Copy Markdown
Contributor

I agree with @Wartori54, in my opinion this is an improvement over the current "Mod Options" menu, and I would keep the search feature as well in both the mod list and for a specific mod options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1: review needed This PR needs 2 approvals to be merged (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested options

7 participants