Refactor refund logic to use UtilHelper for formatting XRPL amounts#437
Open
du1ana wants to merge 2 commits intoEvernodeXRPL:ubuntu-24from
Open
Refactor refund logic to use UtilHelper for formatting XRPL amounts#437du1ana wants to merge 2 commits intoEvernodeXRPL:ubuntu-24from
du1ana wants to merge 2 commits intoEvernodeXRPL:ubuntu-24from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When refunding tenants, the decimal multiplication of
leaseAmount * remainingMomentscan produce values exceeding XRPL's precision limits, causingDecimal precision out of rangeerrors.Steps to Reproduce
0.000001 EVRs) on an Evernode hostev-devkitevernode deleteError
Fix
Introduced
UtilHelper.formatXrplAmount()to ensure XRPL-compliant precision (15 significant digits) when calculating refund amounts.Before:
After: