fix(ce-test-browser): prefer host-native browser drivers#1097
Open
tmchow wants to merge 2 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f37fdbec63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Make fallback setup guidance platform-neutral - Pin semantic ce-setup skill wording in the policy test Note: concurrent full-suite runs in another worktree contended on the shared repo-profile cache; the focused policy test passed 5/5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ce-test-browsercan now use a browser embedded in or directly owned by the active app harness instead of failing because every run was forced throughagent-browser. CLI harnesses and environments without a qualifying native browser retainagent-browseras the portable fallback.Pipeline and LFG runs are still unattended, but unattended no longer means invisible: an integrated browser can remain visible and non-blocking while the run suppresses questions. The original quality guard remains intact -- standalone Playwright, Puppeteer, separately configured browser extensions or MCPs, and ad hoc automation are still rejected.
Driver policy
agent-browserguidance and distinguishes a missing CLI from a browser-runtime launch failure.Validation
bun test-- 1,913 pass, 0 failbun test tests/ce-test-browser-driver-policy.test.ts tests/skill-conventions.test.ts-- 206 pass, 0 failbun run release:validate-- release metadata in syncNew concepts
Host-native capability with a portable fallback
A host-native capability is part of the harness running the agent, not merely another browser tool installed beside it. Preferring that surface lets the harness provide its intended observable experience without giving agents permission to improvise a new automation stack.
agent-browserwhen no qualifying native surface existsAn API named Playwright can still be host-native when it is the harness's own browser API. Do not use this pattern when the native surface lacks a required capability; select the portable fallback before testing begins instead.