Skip to content

feat(product-lens-reviewer): domain-agnostic activation criteria and strategic consequences#481

Merged
tmchow merged 2 commits into
mainfrom
feat/product-lens-criteria
Apr 1, 2026
Merged

feat(product-lens-reviewer): domain-agnostic activation criteria and strategic consequences#481
tmchow merged 2 commits into
mainfrom
feat/product-lens-criteria

Conversation

@tmchow

@tmchow tmchow commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

The product-lens persona was only activating on consumer-product vocabulary ("user stories," "market claims," "business justification"), so it never fired when reviewing plans for developer tools, internal platforms, plugins, or SDKs — even though "are we building the right thing?" is equally valuable in those contexts.

Three changes:

  • SKILL.md activation criteria — replaced vocabulary-matching with a two-leg test: (1) challengeable premise claims about what to build and why, (2) strategic weight beyond the immediate problem. Domain-agnostic — works for any product with users of any kind.
  • Agent protocol step 2 — expanded from a narrow path-dependency check ("trajectory") to a full strategic consequences assessment: trajectory, identity impact, adoption dynamics, opportunity cost, and compounding direction.
  • Product context section — the agent now identifies whether the product is external (open market, marketplace), internal (captive audience), or hybrid, and shifts analysis weights accordingly. External products weight competitive positioning; internal products weight cognitive load, maintenance surface, and workaround risk.

Test plan

  • Run document-review on a developer-tool requirements doc (e.g., CLI readiness persona) and verify product-lens activates
  • Run document-review on a pure housekeeping doc (e.g., todo path consolidation) and verify product-lens does NOT activate
  • Run document-review on a consumer-product requirements doc and verify product-lens still activates (no regression)
  • Verify product-lens findings reference the correct product context (external vs internal) when applicable

🤖 Generated with Claude Code

…strategic consequences

The product-lens persona was only activating on consumer-product vocabulary
(user stories, market claims, business justification), missing developer tools,
internal platforms, and other products where the "are we building the right
thing?" question is equally valuable.

Activation criteria now test for challengeable premise claims and strategic
weight rather than domain-specific vocabulary. The agent gains a product context
section (external vs internal vs hybrid) that shifts analysis weights, and
step 2 expands from narrow path-dependency checks to full strategic consequences:
trajectory, identity impact, adoption dynamics, opportunity cost, and compounding
direction.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 518fec9517

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/compound-engineering/skills/document-review/SKILL.md Outdated
…ne documents

Leg 1 criteria ("problem framing", "goal statements") were broad enough
to match nearly every requirements/plan document, making product-lens
effectively always-on. Tightened each bullet to require genuinely
challengeable premises rather than mere existence of problem framing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tmchow tmchow merged commit 804d78f into main Apr 1, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant