fix(code-review): grant Write to JSON-pipeline reviewer agents#741
Merged
fix(code-review): grant Write to JSON-pipeline reviewer agents#741
Conversation
The ce-code-review subagent template instructs each persona to write its
full analysis to /tmp/compound-engineering/ce-code-review/{run_id}/{reviewer}.json,
and SKILL.md documents this as "the one permitted write." All 17
JSON-pipeline persona agents declared tools: Read, Grep, Glob, Bash --
Write was never granted, so the instructed write was unsatisfiable and
no run-artifact files appeared, breaking headless detail enrichment.
Add Write to the tools allowlist for all 17 personas (always-on,
cross-cutting conditional, and stack-specific). Extend
review-skill-contract.test.ts to assert Write is present so this cannot
regress.
Fixes #733
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persona reviewers spawned by
/ce-code-reviewwere not writing run-artifact files to/tmp/compound-engineering/ce-code-review/<run-id>/, even though the subagent template explicitly instructs each persona to do so as "the one permitted write." Headless detail enrichment depends on those files forWhy:andEvidence:lines, so the missing artifacts silently degraded review output.The cause was a declaration mismatch: all 17 JSON-pipeline persona agents declared
tools: Read, Grep, Glob, Bashin frontmatter —Writewas never granted. The skill's instruction to use the file-write tool was unsatisfiable. AddingWriteto each persona's allowlist makes the documented contract actually executable.Change
ce-correctness-reviewer,ce-testing-reviewer,ce-maintainability-reviewer,ce-project-standards-reviewerce-security-reviewer,ce-performance-reviewer,ce-api-contract-reviewer,ce-data-migrations-reviewer,ce-reliability-reviewer,ce-adversarial-reviewer,ce-previous-comments-reviewerce-dhh-rails-reviewer,ce-kieran-rails-reviewer,ce-kieran-python-reviewer,ce-kieran-typescript-reviewer,ce-julik-frontend-races-reviewer,ce-swift-ios-reviewerUnstructured-output agents (
ce-agent-native-reviewer,ce-learnings-researcher,ce-schema-drift-detector,ce-deployment-verification-agent,ce-data-migration-expert) were left untouched — they don't follow the artifact-write contract.Regression guard
Added
tests/review-skill-contract.test.ts"JSON-pipeline persona agents grant Write so they can save run artifacts", which iterates all 17 personas and assertsWriteis in theirtoolsfrontmatter. The pre-existing assertion only covered Read/Grep/Glob/Bash and missed this gap.bun test(1047 tests) passes;bun run release:validateis clean.Fixes #733