refactor(ce-simplify-code): scope tests by ripple risk, not full suite#749
Merged
refactor(ce-simplify-code): scope tests by ripple risk, not full suite#749
Conversation
Step 4 previously prescribed running the full test suite, lint, and typecheck after every simplification. Default to scoped tests with broaden-on-ripple-risk guidance so verification cost matches the size of the change. Typecheck and lint stay full-project (cheap, broad). CI is the comprehensive backstop.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26898c70e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill
ce-simplify-codenow matches verification cost to the change. Step 4 defaults to scoped tests with a judgment-based escalation rule (broaden when fixes touch heavily-imported utilities or consolidate shared code), instead of always running the full test suite. Typecheck and lint stay full-project, since they're cheap and broad. CI runs the full suite on PR as the comprehensive backstop.