dev.jl/configure boundaries #125
Conversation
|
Review changes with |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 49.17% 49.59% +0.41%
==========================================
Files 27 27
Lines 1948 1968 +20
==========================================
+ Hits 958 976 +18
- Misses 990 992 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jordanxlau
force-pushed
the
dev.jl/configure_boundaries
branch
4 times, most recently
from
e248df1 to
9a7134a
Compare
roedoejet
left a comment
roedoejet
left a comment
There was a problem hiding this comment.
A couple clarifying questions, but it looks good to me - thanks @jordanxlau !
fs2/cli/synthesize.py
Outdated
|
|
||
| text_config: TextConfig = model.config.text | ||
| split_text: bool = text_config.split_text | ||
| strong: str = "" |
There was a problem hiding this comment.
| strong: str = "" | |
| strong_boundaries: str = "" |
There was a problem hiding this comment.
or maybe even strong_textsplit_boundaries
fs2/cli/synthesize.py
Outdated
| text_config: TextConfig = model.config.text | ||
| split_text: bool = text_config.split_text | ||
| strong: str = "" | ||
| weak: str = "" |
There was a problem hiding this comment.
| weak: str = "" | |
| weak_boundaries: str = "" |
fs2/cli/synthesize.py
Outdated
|
|
||
| text_config: TextConfig = model.config.text | ||
| split_text: bool = text_config.split_text | ||
| strong: str = "" |
There was a problem hiding this comment.
same here - we could be a bit more clear in the var name
fs2/tests/test_chunking.py
Outdated
| # Checks that the files have reasonable lengths | ||
| output_one = AudioSegment.from_file( | ||
| output_dir / "one--S1--L1--ckpt=77--v_ckpt=10--pred.wav" | ||
| output_dir / "one--S1--L1--ckpt=77--v_ckpt=10--pred.wav", close=True |
There was a problem hiding this comment.
I don't see close in the documentation - what is this for? https://github.com/jiaaro/pydub/blob/master/API.markdown
jordanxlau
force-pushed
the
dev.jl/configure_boundaries
branch
from
9a7134a to
52a7801
Compare
jordanxlau
force-pushed
the
dev.jl/configure_boundaries
branch
from
52a7801 to
2412d66
Compare
jordanxlau
force-pushed
the
dev.jl/configure_boundaries
branch
from
2412d66 to
9f04b42
Compare
roedoejet
left a comment
roedoejet
left a comment
There was a problem hiding this comment.
lgtm - thanks @jordanxlau !
PR Goal?
Allow the user to configure text chunking boundaries in TextConfig (eg. adding an interrobang or ellipsis to the list of strong boundaries, or a dash to the list of weak boundaries).
For more information see: EveryVoiceTTS/EveryVoice#721.
Tests added?
None in submodule - I believe existing tests in main module cover everything.
Related PRs?
See parent PR: See EveryVoiceTTS/EveryVoice#721