Skip to content

Conversation

@joanise
Copy link
Member

@joanise joanise commented Aug 25, 2025

Quick fix to resolve mypy errors on main branch.

See also EveryVoiceTTS/EveryVoice#736

@semanticdiff-com
Copy link

semanticdiff-com bot commented Aug 25, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  fs2/cli/synthesize.py  45% smaller

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.49%. Comparing base (9f04b42) to head (b647ec5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   49.59%   49.49%   -0.11%     
==========================================
  Files          27       27              
  Lines        1968     1964       -4     
==========================================
- Hits          976      972       -4     
  Misses        992      992              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise joanise requested a review from deltork August 25, 2025 20:44
Code already handled the case by catching KeyError, this is just to appease mypy
@joanise joanise force-pushed the dev.ej/fix-mypy-125 branch from 29255d0 to b647ec5 Compare August 25, 2025 21:12
@joanise joanise merged commit cc2a887 into main Aug 25, 2025
7 checks passed
@joanise joanise deleted the dev.ej/fix-mypy-125 branch August 25, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants