Skip to content

Conversation

@joanise
Copy link
Member

@joanise joanise commented Oct 22, 2025

@semanticdiff-com
Copy link

semanticdiff-com bot commented Oct 22, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  fs2/tests/test_cli.py  96% smaller
  fs2/tests/test_chunking.py  66% smaller
  fs2/config/__init__.py  64% smaller
  fs2/cli/synthesize.py  19% smaller

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.64%. Comparing base (eddda36) to head (83f349e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
fs2/cli/synthesize.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   49.64%   49.64%           
=======================================
  Files          27       27           
  Lines        1982     1984    +2     
=======================================
+ Hits          984      985    +1     
- Misses        998      999    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise joanise force-pushed the dev.ej/misc-for-359 branch from fbf74c2 to 83f349e Compare October 23, 2025 13:12
@joanise joanise changed the title fix: silence some noisy tests Code improvements while working on https://github.com/EveryVoiceTTS/EveryVoice/pull/758 Oct 23, 2025
@joanise joanise changed the title Code improvements while working on https://github.com/EveryVoiceTTS/EveryVoice/pull/758 Code improvements while working on EV PR 758 Oct 23, 2025
@joanise joanise requested a review from roedoejet October 23, 2025 16:11
Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a clarifying question, looks good to me though

default_language: str | None = None,
default_speaker: str | None = None,
output_type: list[SynthesizeOutputFormats] = [],
output_type: Sequence[SynthesizeOutputFormats] = [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this? don't we just mean it to be a list?

Copy link
Member Author

@joanise joanise Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes we pass tuples in, and that's a type mismatch -- we do so in unit tests for sure, maybe elsewhere I forget. I figured it made more sense to make the type annotation more flexible than force the use of actual lists everywhere, given any sequence will behave correctly here.

@joanise joanise merged commit 83f349e into main Oct 28, 2025
7 checks passed
@joanise joanise deleted the dev.ej/misc-for-359 branch October 28, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants