Skip to content

feat: Implement dual-mode user access control system #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bGlzdGRlcg
Copy link

No description provided.

@DeekshithSH
Copy link
Contributor

just curious isn't both ALLOWED_USERS and BLOCK_USERS going to do the same thing

@bGlzdGRlcg
Copy link
Author

Sometimes you may want to make your robot public but not allow some people to use it.

@DeekshithSH
Copy link
Contributor

Sometimes you may want to make your robot public but not allow some people to use it.

Hmm,
Maybe isn't it would be better to make BLOCK_USERS a yes or no (true or false) if true users in ALLOWED_USERS (we could change it to something like USER_IDS) they will be blocked. if false users in ALLOWED_USERS list will be allowed

Add BlockFlag configuration option to control the behavior mode of the UsersID list:
- When BlockFlag is false: Users in the UsersID list are allowed to use the bot
- When BlockFlag is true: Users in the UsersID list are blocked from using the bot
@bGlzdGRlcg
Copy link
Author

Sometimes you may want to make your robot public but not allow some people to use it.

Hmm, Maybe isn't it would be better to make BLOCK_USERS a yes or no (true or false) if true users in ALLOWED_USERS (we could change it to something like USER_IDS) they will be blocked. if false users in ALLOWED_USERS list will be allowed

Done.

@bGlzdGRlcg bGlzdGRlcg changed the title feat: add BLOCK_USERS feature feat: Implement dual-mode user access control system Apr 13, 2025
@DeekshithSH
Copy link
Contributor

Sometimes you may want to make your robot public but not allow some people to use it.

Hmm, Maybe isn't it would be better to make BLOCK_USERS a yes or no (true or false) if true users in ALLOWED_USERS (we could change it to something like USER_IDS) they will be blocked. if false users in ALLOWED_USERS list will be allowed

Done.

I didn't told you to implement it, I was just shared my thoughts
I am not even a collaborator to accept your pull request

@bGlzdGRlcg
Copy link
Author

Sometimes you may want to make your robot public but not allow some people to use it.

Hmm, Maybe isn't it would be better to make BLOCK_USERS a yes or no (true or false) if true users in ALLOWED_USERS (we could change it to something like USER_IDS) they will be blocked. if false users in ALLOWED_USERS list will be allowed

Done.

I didn't told you to implement it, I was just shared my thoughts
I am not even a collaborator to accept your pull request

I just thought it was a good idea and implemented it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants