-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[REFACTOR] Enhancements and Code Cleanup #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: python
Are you sure you want to change the base?
Conversation
DeekshithSH
commented
Mar 24, 2025
- Use fork of Pyrogram (fork by KurimuzonAkuma).
- Show Stream Button when the message contains an audio or video file.
- Remove shortened link.
- Changed import order.
- Removed unused imports and trailing spaces.
- Used lazy formatting in logging.
- Added type hinting.
Removed Unused imports, Trailing spaces Use Lazy formating in logging Type Hinting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions. I've found some small issues.
pyrogram<=2.0.93 | ||
python-dotenv<=0.20.0 | ||
aiohttp<=3.11.14 | ||
kurigram<=2.1.39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You sure this is a good fork? I mean I've seen some pretty good forks too like hydrogram.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hydrogram is also good, but its last commit was 4 months ago, so I wasn't sure if it's still actively maintained. Kurigram, on the other hand, seems to be receiving regular updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'll look into it 👍
This reverts commit bcf0d73.
Use rotating logs to prevent the log file from growing indefinitely and consuming excessive storage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll merge this as soon as I test this code