-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secret Floof Portal to Happiness Added #219
base: master
Are you sure you want to change the base?
Conversation
Hiya @Rendamage , thanks for this. This PR is deffo an improvement! Can you change your image src links so they're not pointing at your C drive? There's no need to include the C drive part in the link, if your image is residing in the images folder, you can just point to that! ⚡ 😃 I recommend that you rebase before you make your changes aswell just in case you've missed anything. |
Hi Evie,
Thanks for the advice. Will do.
All the best,
Renos
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Evie Skinner <[email protected]>
Sent: Tuesday, October 22, 2019 6:29:34 PM
To: Evie-Skinner18/happy_hacktoberfest_19 <[email protected]>
Cc: Rendamage <[email protected]>; Mention <[email protected]>
Subject: Re: [Evie-Skinner18/happy_hacktoberfest_19] Secret Floof Portal to Happiness Added (#219)
Hiya @Rendamage<https://github.com/Rendamage> , thanks for this. This PR is deffo an improvement! Can you change your image src links so they're not pointing at your C drive? There's no need to include the C drive part in the link, if your image is residing in the images folder, you can just point to that! ⚡️ 😃 I recommend that you rebase before you make your changes aswell just in case you've missed anything.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#219?email_source=notifications&email_token=ANKBVTOI6UXP6DOJ46BVK5LQP4Z75A5CNFSM4JC7CV5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6RVOQ#issuecomment-545069754>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANKBVTLUQDI5CZNNUUIWS63QP4Z75ANCNFSM4JC7CV5A>.
|
@Rendamage, would you like to submit a fixed and rebased pull request, or would you like me to do it? |
Hi Isaac, Could you fix this for me. I am not sure I would be able to do it without causing another merge conflict. A good lesson for me at least to remember to submit my code often and to use ../ for my images. |
Need to add links to the events drop down but currently can view with a hard link.