Conversation
Add deprecation warning.
WalkthroughThe PR renames the repository port variable from PORT to GAMEPORT across docs and configuration, and adds backward-compatibility in the startup script to accept PORT while preferring GAMEPORT. No public API or exported signatures changed. Changes
Sequence Diagram(s)(Skipped — changes are limited to docs, compose, and a simple env-var compatibility in a script; no multi-component sequential flow requiring visualization.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-11-26T08:22:42.142ZApplied to files:
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
37-37: Minor formatting: Remove extra space after blockquote symbol.The markdown has multiple spaces after the blockquote symbol.
🔎 Proposed fix
-> +>
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README.mddocker-compose.ymlstart-server.sh
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-26T08:22:42.142Z
Learnt from: EvilOlaf
Repo: EvilOlaf/scum PR: 8
File: README.md:53-56
Timestamp: 2025-11-26T08:22:42.142Z
Learning: In the EvilOlaf/scum repository, providing detailed help with customizing the gaming experience (such as extensive SCUM server configuration guidance) is out of scope. The repository focuses on the Docker container setup rather than comprehensive game server customization documentation.
Applied to files:
README.mddocker-compose.yml
🪛 markdownlint-cli2 (0.18.1)
README.md
37-37: Multiple spaces after blockquote symbol
(MD027, no-multiple-space-blockquote)
🔇 Additional comments (4)
docker-compose.yml (1)
6-6: LGTM! Environment variable renamed for clarity.The change from
PORTtoGAMEPORTimproves clarity. The backward compatibility layer instart-server.shensures existing deployments won't break.README.md (1)
31-31: LGTM! Documentation consistently updated.All references to the port environment variable have been correctly updated from
PORTtoGAMEPORTthroughout the documentation, including the usage example and footnote.Also applies to: 34-34, 40-40, 83-83
start-server.sh (2)
4-13: LGTM! Backward compatibility implemented correctly.The deprecation logic properly handles the migration path:
- Clear warning message guides users to update their configuration
GAMEPORT="${GAMEPORT:-$PORT}"correctly prioritizesGAMEPORTif both variables are set- Prevents breaking existing deployments
39-39: LGTM! Server invocation updated correctly.The port parameter now uses
GAMEPORTwith the same default value (7777), maintaining existing behavior while supporting the new variable name.
and add deprecation warning.
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.