feat: integrate MINERVA benchmark with Lance-backed video mode and pipeline latency guidance#1121
Merged
Luodian merged 5 commits intoFeb 21, 2026
Conversation
kcz358
reviewed
Feb 21, 2026
Comment on lines
+548
to
+555
| Lance mode variables: | ||
|
|
||
| ```bash | ||
| export MINERVA_LANCE_VIDEO_URI="hf://datasets/lmms-lab-eval/minerva/data/train.lance" | ||
| export MINERVA_LANCE_VIDEO_ID_COLUMN="video_id" | ||
| export MINERVA_LANCE_VIDEO_BLOB_COLUMN="video_blob" | ||
| export MINERVA_LANCE_CACHE_DIR="~/.cache/lmms_eval/minerva_lance_videos" | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Looks quite hardcoded right now if want to use lance db. Possibly can have an lance db reader via hf api if we are using hub and we might need a unified dataset format for lancedb type dataset.
Contributor
Author
|
interesting, copilot hallucinates on the package name, it should be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minervatask integration with task YAML/template, scoring utilities, and optional Lance-backed video blob resolutiontools/minerva_to_lance.pyto convert local MINERVA metadata + downloaded videos into a Lance dataset (video_blobenabled)tools/bench_minerva_video_resolution.py) and fixed-pipeline storage comparison (tools/bench_minerva_pipeline_latency.py)Review Feedback Triage (Copilot + Maintainer)
lmms_eval/tasks/minerva/utils.py: thread-safe resolver init, blob resource cleanup, safer answer-letter extraction, emptyvideo_idhandling, deprecated key warning, and logurueval_loggerconsistencytools/minerva_to_lance.py: explicit empty-metadata validation, missing-file accounting, sample missing ID reporting, and hard failure when no rows are writablepylanceis the Python package that exposes thelanceimport moduleValidation
uv run python tools/bench_minerva_pipeline_latency.py --local-video-dir data/minerva/videos --lance-uri data/minerva_hf_package/data/train.lance --lance-cache-dir /tmp/minerva_lance_cache_bench_20260221_v3 --limit 100 --batch-size 1 --decode-num-frames 8 --output-root /tmp/minerva_pipeline_latency_20260221_v3total_mean_ms=529.845,decode_mean_ms=529.535,videos_per_s=1.887total_mean_ms=533.630,decode_mean_ms=528.902,videos_per_s=1.874lance/local total_mean=1.007(about +0.7%)uv run python tools/bench_minerva_pipeline_latency.py --local-video-dir data/minerva/videos --lance-uri data/minerva_hf_package/data/train.lance --lance-cache-dir /tmp/minerva_lance_cache_probe_1121 --limit 10 --batch-size 1 --decode-num-frames 4 --output-root /tmp/minerva_pipeline_latency_probe_1121uv run python -m py_compile lmms_eval/tasks/minerva/utils.py tools/minerva_to_lance.py lmms_eval/models/model_utils/load_video.py tools/bench_minerva_pipeline_latency.py tools/bench_minerva_video_resolution.py lmms_eval/models/simple/dummy_video_reader.pylsp_diagnosticsclean for touched Python files