Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lmms_eval/api/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ def set_cache_hook(self, cache_hook) -> None:
self.cache_hook = cache_hook

def clean(self):
accelerator = getattr(self, "accelerator", None)
if accelerator is not None and hasattr(accelerator, "free_memory"):
accelerator.free_memory()

for attr_name in list(vars(self)):
attr_value = getattr(self, attr_name)
if isinstance(attr_value, nn.Module):
Expand Down
38 changes: 38 additions & 0 deletions test/models/test_model_cleanup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import torch

from lmms_eval.api.model import lmms


class _DummyLM(lmms):
def loglikelihood(self, requests):
return []

def generate_until(self, requests):
return []

def generate_until_multi_round(self, requests):
return []


class _FakeAccelerator:
def __init__(self, model):
self._models = [model]
self.free_memory_calls = 0

def free_memory(self):
self.free_memory_calls += 1
self._models = []


def test_clean_releases_accelerator_model_references():
lm = _DummyLM()
model = torch.nn.Linear(1, 1)
accelerator = _FakeAccelerator(model)
lm._model = model
lm.accelerator = accelerator

lm.clean()

assert accelerator.free_memory_calls == 1
assert accelerator._models == []
assert not hasattr(lm, "_model")
Loading